How to upstream patch for Couchbase v5.1 with custom CLA?


#1

Hi,

I have a patch ready for making Couchbase v5.1 work on Power8/LE (ppc64le) platform. I would like to submit it for review. I understand that there is CLA which needs to be signed. However, I do have a custom CLA which is signed with my employer. Is there any way to submit that instead of the regular one?

Thanks,
Atul.


#2

@anil Is this something you can help with?


#3

@drigby @anil Is there any update about using custom CLA? Thanks!


#4

Anil’s probably you’re man (Product Management).

If you just sign the CLA as-is that’s probably the quickest route.


#5

@drigby I think IBM custom CLA has already been recognized by Couchbase community as per the conversation here: https://issues.couchbase.com/browse/MB-31350
@shivani_g (Ms. Shivani Gupta) is involved in the above mentioned thread.


#6

Ok. So I think we can manually “approve” your Gerrit account based on the company CLA you have signed.

Can you proceed with the normal steps to submit code (see https://github.com/couchbase/libcouchbase/blob/master/CONTRIBUTING.md) ; when you get to “signing the CLA” step let us know (including your username) and we should be able to manually add you.


#7

Hi @drigby,

For creating PRs I confirm that we can use the same CLA mentioned in https://issues.couchbase.com/browse/MB-31350

I am ready with the code and can submit it raising PRs, so could you please add my username “kbhute-ibm” to the account. Thanks in advance.


#8

@koumudini.bhute I’ve updated our Gerrit instance to support the IBM CLA. However I cannot see your account on there to add it to the CLA group. Have you created an account on review.couchbase.org? You just need to log in over there using your GitHub credentials. Since it uses OAuth I cannot do that step for you. But once it’s done, let me know and I’ll add you to the CLA group.


#9

Hi @ceej

Thanks for the prompt response. I had already signed in to review.couchbase.org with my Github credentials i.e. ‘kbhute-ibm’. When I logged in, I could see under http://review.couchbase.org/#/settings/agreements is:

I think now I am added to CLA group. Please confirm.

Also please find below my profile details:

Username kbhute-ibm
Full Name kbhute-ibm
Email Address
Registered Aug 20, 2018 4:19 PM
Account ID 1004362

With above information, please let me know what next step I need to follow. Thanks in advance.


#10

@koumudini.bhute I could not find your Gerrit account earlier, but I’ve found it now and added it to the IBM CLA group. You should see it listed under http://review.couchbase.org/#/settings/agreements ; please ensure it is there (the screenshot above is from a slightly different page).

Once that’s there, the CONTRIBUTING.md URL posted by Dave Rigby should tell you what you need to know about proposing a change to Gerrit. You’ll need to add an ssh public key at http://review.couchbase.org/#/settings/ssh-keys and then ensure that your SSH configuration is such that it will use your key. You can verify your SSH configuration by running

ssh -p 29418 kbhute-ibm@review.couchbase.org

You should see something like

**** Welcome to Gerrit Code Review ****

Hi Chris Hillery, you have successfully connected over SSH.


#11

Thanks @ceej Yes I could see IBM CLA in agreements section now.
For code change proposal to Gerrit, I will get refer the doc and get in touch with @drigby in case of any challenges.